aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDeterminant <[email protected]>2017-11-16 01:50:38 -0500
committerDeterminant <[email protected]>2017-11-16 01:50:38 -0500
commit47af523921dab40e68259f7e58bc535474630b5a (patch)
tree0d87f7616b52b6b5afd3737586dbe0facf0b48de
parentd9e06bb66288bcbc893b0f41571cc4a710e1f973 (diff)
clear bg_pixel when it is not rendering
-rw-r--r--src/ppu.rs20
1 files changed, 12 insertions, 8 deletions
diff --git a/src/ppu.rs b/src/ppu.rs
index c5b4aec..54dbc0b 100644
--- a/src/ppu.rs
+++ b/src/ppu.rs
@@ -488,9 +488,10 @@ impl<'a> PPU<'a> {
self.cycle = cycle + 1;
return false;
}
+ let rendering = self.get_show_bg() || self.get_show_sp();
let visible_line = self.scanline < 240;
let pre_line = self.scanline == 261;
- if (pre_line || visible_line) && (self.get_show_bg() || self.get_show_sp()) {
+ if (pre_line || visible_line) && rendering {
if pre_line && 279 < cycle && cycle < 305 {
self.reset_y();
} else {
@@ -534,14 +535,17 @@ impl<'a> PPU<'a> {
self.bg_pixel = 0;
}
}
- } else if self.scanline == 241 && cycle == 1 {
- if !self.early_read {
- self.ppustatus |= PPU::FLAG_VBLANK;
+ } else {
+ if !rendering { self.bg_pixel = 0 }
+ if self.scanline == 241 && cycle == 1 {
+ if !self.early_read {
+ self.ppustatus |= PPU::FLAG_VBLANK;
+ }
+ self.scr.render();
+ self.cycle += 1;
+ self.early_read = false;
+ return !self.early_read && self.get_flag_nmi(); /* trigger cpu's NMI */
}
- self.scr.render();
- self.cycle += 1;
- self.early_read = false;
- return !self.early_read && self.get_flag_nmi(); /* trigger cpu's NMI */
}
self.cycle += 1;
if self.cycle > 340 {