From 870d09e53d93eee04e06fd225bfe4b124b7610aa Mon Sep 17 00:00:00 2001
From: Determinant <ted.sybil@gmail.com>
Date: Fri, 23 Aug 2019 13:46:13 -0400
Subject: fix bugs

---
 include/hotstuff/consensus.h |  8 ++++----
 include/hotstuff/entity.h    | 10 ++--------
 include/hotstuff/liveness.h  |  1 +
 3 files changed, 7 insertions(+), 12 deletions(-)

(limited to 'include')

diff --git a/include/hotstuff/consensus.h b/include/hotstuff/consensus.h
index e0f2ecc..8a4f5f0 100644
--- a/include/hotstuff/consensus.h
+++ b/include/hotstuff/consensus.h
@@ -44,7 +44,7 @@ class HotStuffCore {
     uint32_t vheight;          /**< height of the block last voted for */
     /* === auxilliary variables === */
     privkey_bt priv_key;            /**< private key for signing votes */
-    std::set<block_t, BlockHeightCmp> tails;   /**< set of tail blocks */
+    std::set<block_t> tails;   /**< set of tail blocks */
     ReplicaConfig config;                   /**< replica configuration */
     /* === async event queues === */
     std::unordered_map<block_t, promise_t> qc_waiting;
@@ -158,11 +158,11 @@ class HotStuffCore {
     promise_t async_hqc_update();
 
     /* Other useful functions */
-    const block_t &get_genesis() { return b0; }
+    const block_t &get_genesis() const { return b0; }
     const block_t &get_hqc() { return hqc.first; }
-    const ReplicaConfig &get_config() { return config; }
+    const ReplicaConfig &get_config() const { return config; }
     ReplicaID get_id() const { return id; }
-    const std::set<block_t, BlockHeightCmp> get_tails() const { return tails; }
+    const std::set<block_t> get_tails() const { return tails; }
     operator std::string () const;
     void set_vote_disabled(bool f) { vote_disabled = f; }
 };
diff --git a/include/hotstuff/entity.h b/include/hotstuff/entity.h
index 12d92cc..b3bf6a8 100644
--- a/include/hotstuff/entity.h
+++ b/include/hotstuff/entity.h
@@ -186,15 +186,9 @@ class Block {
 
     const uint256_t &get_hash() const { return hash; }
 
-    bool verify(const ReplicaConfig &config) const {
-        if (qc && !qc->verify(config)) return false;
-        return true;
-    }
+    bool verify(const HotStuffCore *hsc) const;
 
-    promise_t verify(const ReplicaConfig &config, VeriPool &vpool) const {
-        return (qc ? qc->verify(config, vpool) :
-        promise_t([](promise_t &pm) { pm.resolve(true); }));
-    }
+    promise_t verify(const HotStuffCore *hsc, VeriPool &vpool) const;
 
     int8_t get_decision() const { return decision; }
 
diff --git a/include/hotstuff/liveness.h b/include/hotstuff/liveness.h
index b0373ed..452ecdc 100644
--- a/include/hotstuff/liveness.h
+++ b/include/hotstuff/liveness.h
@@ -73,6 +73,7 @@ class PMHighTail: public virtual PaceMaker {
     
     void reg_hqc_update() {
         hsc->async_hqc_update().then([this](const block_t &hqc) {
+            hqc_tail = hqc;
             for (const auto &tail: hsc->get_tails())
                 if (check_ancestry(hqc, tail) && tail->get_height() > hqc_tail->get_height())
                     hqc_tail = tail;
-- 
cgit v1.2.3-70-g09d2