From b89114d6abd140dcd1fbf6e4e64fcba508a9f59c Mon Sep 17 00:00:00 2001
From: Aaron Buchwald <aaron.buchwald56@gmail.com>
Date: Thu, 17 Dec 2020 14:14:19 -0500
Subject: Address comments
---
.ci/lint.sh | 2 +-
.golangci.yml | 2 --
plugin/evm/vm.go | 2 +-
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/.ci/lint.sh b/.ci/lint.sh
index cde7292..e2ee0ce 100755
--- a/.ci/lint.sh
+++ b/.ci/lint.sh
@@ -9,4 +9,4 @@ export PATH=$PATH:$(go env GOPATH)/bin
golangci-lint --version
-golangci-lint run --max-same-issues 0
\ No newline at end of file
+golangci-lint run --max-same-issues 0
diff --git a/.golangci.yml b/.golangci.yml
index 18b325e..d2a5e38 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -19,9 +19,7 @@ linters:
- govet
- ineffassign
- misspell
- # - staticcheck
- unconvert
- # - unused
- varcheck
linters-settings:
diff --git a/plugin/evm/vm.go b/plugin/evm/vm.go
index c9bdad9..1caa9e9 100644
--- a/plugin/evm/vm.go
+++ b/plugin/evm/vm.go
@@ -739,7 +739,7 @@ func (vm *VM) writeBackMetadata() {
// awaitTxPoolStabilized waits for a txPoolHead channel event
// and notifies the VM when the tx pool has stabilized to the
// expected block hash
-// Waits for signal to shutdown from txPoolStabilizedShutdownChan chan
+// Waits for signal to shutdown from [vm.shutdownChan]
func (vm *VM) awaitTxPoolStabilized() {
defer vm.shutdownWg.Done()
for {
--
cgit v1.2.3-70-g09d2
From 5f6acbf70cb34f8e7978ae5ef4b2c323b2605ff4 Mon Sep 17 00:00:00 2001
From: Aaron Buchwald <aaron.buchwald56@gmail.com>
Date: Thu, 17 Dec 2020 14:14:45 -0500
Subject: Reduce overhead in ci lint script
---
.ci/lint.sh | 4 ----
1 file changed, 4 deletions(-)
diff --git a/.ci/lint.sh b/.ci/lint.sh
index e2ee0ce..e5363a8 100755
--- a/.ci/lint.sh
+++ b/.ci/lint.sh
@@ -1,9 +1,5 @@
# binary will be $(go env GOPATH)/bin/golangci-lint
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.30.0
-# or install it into ./bin/
-curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.30.0
-# In alpine linux (as it does not come with curl by default)
-wget -O- -nv https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.30.0
export PATH=$PATH:$(go env GOPATH)/bin
--
cgit v1.2.3-70-g09d2
From 4bfc175770fa006387ca1ffd2360fc0665dfcbf3 Mon Sep 17 00:00:00 2001
From: Aaron Buchwald <aaron.buchwald56@gmail.com>
Date: Thu, 17 Dec 2020 14:21:12 -0500
Subject: Change name of CI linting job
---
.github/workflows/ci.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index b371b2f..c5ef50b 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -3,7 +3,7 @@ on: [pull_request, push]
jobs:
lint:
- name: Golang v${{ matrix.go }} (${{ matrix.os }})
+ name: Lint Golang v${{ matrix.go }} (${{ matrix.os }})
runs-on: ${{ matrix.os }}
strategy:
matrix:
--
cgit v1.2.3-70-g09d2